bpo-31904: Skip setting RLIMIT_FSIZE and RLIMIT_CPU test case for VxWorks #12719
Conversation
set RLIMIT_FSIZE and RLIMIT_CPU
Lib/test/test_resource.py
Outdated
| # an error. | ||
| self.assertEqual(resource.RLIM_INFINITY, max) | ||
| resource.setrlimit(resource.RLIMIT_FSIZE, (cur, max)) | ||
| if _support_rlimit_fsize_set: |
There was a problem hiding this comment.
Please remove the 2 constants and add a decorator to the function:
@skipIf(sys.platform == "vxworks", "setting RLIMIT_FSIZE is not supported on VxWorks")
And make a similar change for the other function.
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! : please review the changes made to this pull request. |
| @@ -0,0 +1 @@ | |||
| Skip setting RLIMIT_FSIZE and RLIMIT_CPU test case for VxWorks | |||
There was a problem hiding this comment.
Please move this NEWS entry to the Misc/NEWS.d/next/Tests/ directory, and mention the name of the fixed test, for example:
Port test_resource to VxWorks: skip tests cases setting RLIMIT_FSIZE and RLIMIT_CPU.
Doc/library/resource.rst
Outdated
| ``setrlimit`` may also raise :exc:`error` if the underlying system call | ||
| fails. | ||
|
|
||
| VxWorks only support setting RLIMIT_NOFILE and idtype must be P_PID. |
There was a problem hiding this comment.
"supports" with a S, no? (I'm not sure, English is not my first language!) Please use :data: to format properly the RLIMIT_NOFILE constant.
| VxWorks only support setting RLIMIT_NOFILE and idtype must be P_PID. | |
| VxWorks only supports setting :data:`RLIMIT_NOFILE` and idtype must be P_PID. |
I don't understand "idtype must be P_PID": what does it mean? Is it something specific to VxWorks?
There was a problem hiding this comment.
Yes, it's VxWorks specific requires.
There was a problem hiding this comment.
I remove that statements for python user doesn't need to care about it.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
4 participants
Skip setting RLIMIT_FSIZE and RLIMIT_CPU test case for VxWorks
https://bugs.python.org/issue31904