Added a warning to the urljoin docs, indicating that it is not safe to use with attacker controlled URLs #126659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o use with attacker controlled URLs This was flagged to me at a party today by someone who works in red-teaming as a frequently encountered footgun. Documenting the potentially unexpected behavior seemed like a good place to start.
Coffigny94
reviewed
Nov 11, 2024
| ``urljoin("https://website.com/users/", username)``, if ``username`` can | ||
| contain an absolute URL, the result of ``urljoin`` will be the absolute | ||
| URL. | ||
|
|
||
|
|
||
| .. versionchanged:: 3.5 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Eclips4
approved these changes
Nov 15, 2024
Eclips4
added
needs backport to 3.12
|
@Eclips4 Thanks for the review! I'm forgetting the workflow here, do I merge? |
Yup. @miss-islington will take care of backports to 3.12 and 3.13. |
|
Great, thanks. |
|
Thanks @alex for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 15, 2024
…o use with attacker controlled URLs (pythonGH-126659) This was flagged to me at a party today by someone who works in red-teaming as a frequently encountered footgun. Documenting the potentially unexpected behavior seemed like a good place to start. (cherry picked from commit d6bcc15) Co-authored-by: Alex Gaynor <[email protected]>
|
GH-126888 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 15, 2024
…o use with attacker controlled URLs (pythonGH-126659) This was flagged to me at a party today by someone who works in red-teaming as a frequently encountered footgun. Documenting the potentially unexpected behavior seemed like a good place to start. (cherry picked from commit d6bcc15) Co-authored-by: Alex Gaynor <[email protected]>
|
GH-126889 is a backport of this pull request to the 3.12 branch. |
Eclips4
pushed a commit
that referenced
this pull request
Nov 15, 2024
… safe to use with attacker controlled URLs (GH-126659) (#126888) Added a warning to the urljoin docs, indicating that it is not safe to use with attacker controlled URLs (GH-126659) This was flagged to me at a party today by someone who works in red-teaming as a frequently encountered footgun. Documenting the potentially unexpected behavior seemed like a good place to start. (cherry picked from commit d6bcc15) Co-authored-by: Alex Gaynor <[email protected]>
Eclips4
pushed a commit
that referenced
this pull request
Nov 15, 2024
… safe to use with attacker controlled URLs (GH-126659) (#126889) Added a warning to the urljoin docs, indicating that it is not safe to use with attacker controlled URLs (GH-126659) This was flagged to me at a party today by someone who works in red-teaming as a frequently encountered footgun. Documenting the potentially unexpected behavior seemed like a good place to start. (cherry picked from commit d6bcc15) Co-authored-by: Alex Gaynor <[email protected]>
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…o use with attacker controlled URLs (pythonGH-126659) This was flagged to me at a party today by someone who works in red-teaming as a frequently encountered footgun. Documenting the potentially unexpected behavior seemed like a good place to start.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…o use with attacker controlled URLs (pythonGH-126659) This was flagged to me at a party today by someone who works in red-teaming as a frequently encountered footgun. Documenting the potentially unexpected behavior seemed like a good place to start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was flagged to me at a party today by someone who works in red-teaming as a frequently encountered footgun. Documenting the potentially unexpected behavior seemed like a good place to start.
📚 Documentation preview 📚: https://cpython-previews--126659.org.readthedocs.build/