Skip to content

[3.13] gh-109413: Add more type hints to libregrtest (GH-126352) #126388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 4, 2024

(cherry picked from commit bfc1d25)

Co-authored-by: sobolevn [email protected]

@sobolevn sobolevn enabled auto-merge (squash) November 4, 2024 10:18
@Yhg1s
Copy link
Member

Yhg1s commented Dec 2, 2024

This backport seems to have some test failures and merge conflicts that need looking at.

@sobolevn
Copy link
Member

sobolevn commented Dec 2, 2024

Fixing! Thanks for the ping.

@vstinner
Copy link
Member

@sobolevn: There are conflicts again, and many CI tests are failing.

  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/libregrtest/runtests.py", line 109, in RunTests
    def create_worker_runtests(self, **override) -> WorkerRunTests:
                                                    ^^^^^^^^^^^^^^
NameError: name 'WorkerRunTests' is not defined

@sobolevn
Copy link
Member

sobolevn commented Jan 8, 2025

Done, should be fixed now. Sorry for the long delay.

@sobolevn sobolevn merged commit 32012ed into python:3.13 Jan 8, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants