Skip to content

[3.9] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697) #125576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2024
Merged

[3.9] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697) #125576

merged 2 commits into from
Oct 28, 2024

Conversation

encukou
Copy link
Member

@encukou encukou commented Oct 16, 2024

This skips tarfile's chmod-related tests on

  • systems where setting suid/sgid is no-op (which are unsupported), and
  • systems where setting the sticky bit is an OSError (like the tier-3 FreeBSD)

This also adds a few directory-related tests, which were originally omitted because they failed on some platforms. Now they will be skipped on those platforms.

In 3.11+ this was done with two commits, GH-108368 & GH-109697:

(cherry-picked from 40e52c9)
(cherry-picked from 26e06ad)

One builds on the other. IMO it makes sense to backport it all, so that these tests are the same as in 3.11+.

encukou and others added 2 commits October 15, 2024 18:32
@encukou
pythongh-107902: Don't test setting suid/sgid on systems that don't s…
5a5b9b9 
…upport them (pythonGH-108368)
@vstinner @encukou
pythongh-108948: Skip test_tarfile.test_modes() on EFTYPE error (pyth…
7ab6520 
…on#109697)

On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.
@encukou encukou requested a review from ethanfurman as a code owner October 16, 2024 11:29
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review skip news labels Oct 16, 2024
This was referenced Oct 16, 2024
Closed
Merged
@encukou
Copy link
Member Author

encukou commented Oct 16, 2024

!buildbot FreeBSD

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 7ab6520 🤖

The command will test the builders whose names match following regular expression: FreeBSD

The builders matched are:

  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD PR
  • AMD64 FreeBSD14 PR

@encukou encukou mentioned this pull request Oct 22, 2024
Closed
@ambv ambv merged commit eb16397 into python:3.9 Oct 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Assignees

@ambv ambv

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@encukou @bedevere-bot @zware @ambv @vstinner