Skip to content

gh-125383: Update fib function comment for accuracy #125386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2024
Merged

gh-125383: Update fib function comment for accuracy #125386

merged 1 commit into from
Oct 13, 2024

Conversation

Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Oct 13, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Oct 13, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 13, 2024
Closed
@Eclips4 Eclips4 changed the title gh-125383: Fix defining Functions example is slightly misleading gh-125383: Update fib function comment for accuracy Oct 13, 2024
@Eclips4 Eclips4 added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 13, 2024
@Eclips4 Eclips4 merged commit 283ea5f into python:main Oct 13, 2024
31 checks passed
@miss-islington-app
Copy link

Thanks @Wulian233 for the PR, and @Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 13, 2024
@Wulian233 @miss-islington
pythongh-125383: Update fib function comment for accuracy (pythonGH…
7776f1f 
…-125386)

`Doc/tutorial/controlflow.rst`: fix comment for `fib` function
(cherry picked from commit 283ea5f)

Co-authored-by: Wulian <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 13, 2024
@Wulian233 @miss-islington
pythongh-125383: Update fib function comment for accuracy (pythonGH…
47968fd 
…-125386)

`Doc/tutorial/controlflow.rst`: fix comment for `fib` function
(cherry picked from commit 283ea5f)

Co-authored-by: Wulian <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 13, 2024

GH-125395 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 13, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 13, 2024

GH-125396 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 13, 2024
Eclips4 pushed a commit that referenced this pull request Oct 13, 2024
@miss-islington @Wulian233
[3.13] gh-125383: Update fib function comment for accuracy (GH-125386…
c9ead96 
…) (#125395)

gh-125383: Update `fib` function comment for accuracy (GH-125386)

`Doc/tutorial/controlflow.rst`: fix comment for `fib` function
(cherry picked from commit 283ea5f)

Co-authored-by: Wulian <[email protected]>
Eclips4 pushed a commit that referenced this pull request Oct 13, 2024
@miss-islington @Wulian233
[3.12] gh-125383: Update fib function comment for accuracy (GH-125386…
00c596d 
…) (#125396)

gh-125383: Update `fib` function comment for accuracy (GH-125386)

`Doc/tutorial/controlflow.rst`: fix comment for `fib` function
(cherry picked from commit 283ea5f)

Co-authored-by: Wulian <[email protected]>
@Wulian233 Wulian233 deleted the fib branch October 13, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev approved these changes

@rruuaanng rruuaanng rruuaanng approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wulian233 @skirpichev @rruuaanng @Eclips4