Skip to content

gh-125025: _thread docs: fix/update the *caveats* list #125026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

zuo
Copy link
Contributor

@zuo zuo commented Oct 6, 2024

Update the first bullet point in the caveats list, and entirely remove the last one.


📚 Documentation preview 📚: https://cpython-previews--125026.org.readthedocs.build/

@zuo
Copy link
Contributor Author

zuo commented Oct 6, 2024

Here, I address a request to a core developer who is an expert in threading, able to competently confirm or correct the suggested changes.

cc @gpshead

(I looked at this list: https://devguide.python.org/core-developers/experts/)

@zuo
Copy link
Contributor Author

zuo commented Oct 6, 2024

PS I believe, these changes, if accepted, will be worth backporting to older versions' docs.

@gpshead gpshead merged commit 1e098dc into python:main Oct 6, 2024
29 checks passed
@gpshead gpshead added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 6, 2024
@miss-islington-app
Copy link

Thanks @zuo for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @zuo for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 6, 2024

GH-125031 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 6, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 6, 2024

GH-125032 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 6, 2024
gpshead pushed a commit that referenced this pull request Oct 6, 2024
…25026) (GH-125031)

gh-125025: `_thread` docs: fix/update the *caveats* list (GH-125026)
(cherry picked from commit 1e098dc)

Co-authored-by: Jan Kaliszewski <[email protected]>
Yhg1s pushed a commit that referenced this pull request Oct 7, 2024
…25026) (#125032)

gh-125025: `_thread` docs: fix/update the *caveats* list (GH-125026)
(cherry picked from commit 1e098dc)

Co-authored-by: Jan Kaliszewski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants