Skip to content

Conversation

freakboy3742
Copy link
Contributor

#123620 added shims for clang++ on iOS; however, those shims won't be autodetected without an update to the configure script.

@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 63e50e1 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ned-deily ned-deily merged commit d359c7c into python:main Sep 6, 2024
45 checks passed
@miss-islington-app
Copy link

Thanks @freakboy3742 for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 6, 2024
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 6, 2024

GH-123758 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 6, 2024
@freakboy3742 freakboy3742 deleted the cxx-autodetect branch September 6, 2024 02:13
freakboy3742 added a commit that referenced this pull request Sep 6, 2024
Ensure clang++ is autodetected on iOS. (gh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 6, 2024
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 6, 2024
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 6, 2024
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 6, 2024
…n#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
@encukou
Copy link
Member

encukou commented Sep 6, 2024

Process nitpick: In the future, please don't use skip issue for PRs that might need backports. The issue number is how related PRs get grouped together.

freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 9, 2024
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 9, 2024
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 9, 2024
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 9, 2024
…n#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Oct 9, 2024
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Dec 13, 2024
…n#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Dec 13, 2024
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Dec 13, 2024
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Dec 13, 2024
…on#123758)

Ensure clang++ is autodetected on iOS. (pythongh-123749)
(cherry picked from commit d359c7c)

Co-authored-by: Russell Keith-Magee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes OS-ios skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants