-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
gh-123392: Clarify wording regarding parameters that are functions to be called #123394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good because that's how object_pairs_hook
and object_hook
are documented. Well, personally I would have kept the current wording and only updated those two but I don't mind to be a bit more verbose if needed.
Just waiting for the changes to be done before accepting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nitpick: we wrap lines at 80 chars. I don't know whether the RST is now more than 80 chars wide or not but if it's the case, can you make the RST fit on 80 characters? (be careful that your lines do not have trailing whitespaces).
Hey @picnixz -- sure thing, nitpicks welcome! I made the change in da35e8b. Let me know if you see any other way to improve the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good unless I missed an obvious typo.
Thanks @ryan-duve for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…ons to be called (pythonGH-123394) (cherry picked from commit c08ede2) Co-authored-by: ryan-duve <[email protected]>
GH-123664 is a backport of this pull request to the 3.13 branch. |
…ons to be called (pythonGH-123394) (cherry picked from commit c08ede2) Co-authored-by: ryan-duve <[email protected]>
GH-123665 is a backport of this pull request to the 3.12 branch. |
…ions to be called (GH-123394) (GH-123664) (cherry picked from commit c08ede2) Co-authored-by: ryan-duve <[email protected]>
…ions to be called (GH-123394) (GH-123665) (cherry picked from commit c08ede2) Co-authored-by: ryan-duve <[email protected]>
Fix for #123392 to clarify wording on callable parameters in documentation.
📚 Documentation preview 📚: https://cpython-previews--123394.org.readthedocs.build/