Skip to content

[3.13] gh-122695: Fix double-free when using gc.get_referents with a freed _asyncio.FutureIter #122837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 9, 2024
Merged

[3.13] gh-122695: Fix double-free when using gc.get_referents with a freed _asyncio.FutureIter #122837

merged 5 commits into from
Aug 9, 2024

Conversation

ZeroIntensity
Copy link
Member

@bedevere-app bedevere-app bot mentioned this pull request Aug 8, 2024
Closed
@colesbury colesbury requested a review from vstinner August 8, 2024 19:09
@colesbury
Copy link
Contributor

I think it's worth including the test case from #122834

@ZeroIntensity
Copy link
Member Author

I think it's worth including the test case from #122834

Oh yeah, forgot to add that here as well. It's there now.

@vstinner vstinner mentioned this pull request Aug 9, 2024
Closed
vstinner
vstinner reviewed Aug 9, 2024
View reviewed changes
vstinner
vstinner reviewed Aug 9, 2024
View reviewed changes
@ZeroIntensity ZeroIntensity requested a review from vstinner August 9, 2024 10:08
vstinner
vstinner reviewed Aug 9, 2024
View reviewed changes
vstinner
vstinner approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
Copy link
Member

vstinner commented Aug 9, 2024

Changes in the 3.13 branch currently need approvals from two core devs.

@ZeroIntensity
Copy link
Member Author

@colesbury, could you take a look?

@kumaraditya303 kumaraditya303 merged commit e8fb088 into python:3.13 Aug 9, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks @ZeroIntensity for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @ZeroIntensity and @kumaraditya303, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e8fb088dbaa71dd5f0146b2f4a8f7ecbe2ce9625 3.12

@ZeroIntensity ZeroIntensity deleted the gc-segfault-fix-313 branch August 9, 2024 14:07
@bedevere-app
Copy link

bedevere-app bot commented Aug 9, 2024

GH-122859 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Aug 9, 2024
vstinner pushed a commit to vstinner/cpython that referenced this pull request Aug 9, 2024
@ZeroIntensity @vstinner
[3.13] pythongh-122695: Fix double-free when using gc.get_referents…
5d77c37 
… with a freed `_asyncio.FutureIter` (python#122837)

* Backport python#122834 for 3.13

(cherry picked from commit e8fb088)
vstinner added a commit that referenced this pull request Aug 9, 2024
@vstinner @ZeroIntensity
[3.12] gh-122695: Fix double-free when using gc.get_referents with …
c57a33d 
…a freed `_asyncio.FutureIter` (#122837) (#122859)

[3.13] gh-122695: Fix double-free when using `gc.get_referents` with a freed `_asyncio.FutureIter` (#122837)

* Backport #122834 for 3.13

(cherry picked from commit e8fb088)

Co-authored-by: Peter Bierma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@colesbury colesbury colesbury approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

@kumaraditya303 kumaraditya303

Labels
topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZeroIntensity @colesbury @vstinner @kumaraditya303