gh-122029: Log call events in sys.setprofile when it's a method with c function #122072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaogaotiantian
added
needs backport to 3.12
gaogaotiantian
requested review from
jaraco,
sethmlarson,
brettcannon,
freakboy3742,
ericsnowcurrently,
erlend-aasland,
barneygale,
corona10,
FFY00,
encukou,
hauntsaninja,
ethanfurman,
JelleZijlstra,
AlexWaygood,
terryjreedy,
pfmoore,
pradyunsg,
ericvsmith,
rhettinger,
a team and
berkerpeksag
as code owners
gaogaotiantian
removed request for
FFY00,
hauntsaninja,
erlend-aasland,
sethmlarson,
terryjreedy,
lysnikolaou,
ezio-melotti,
Fidget-Spinner,
brandtbucher,
isidentical,
kumaraditya303 and
AlexWaygood
gpshead
approved these changes
Jul 23, 2024
|
Thanks @gaogaotiantian for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 23, 2024
… with c function (pythonGH-122072) Log call events in sys.setprofile when it is a method with a C function. (cherry picked from commit e91ef13) Co-authored-by: Tian Gao <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 23, 2024
… with c function (pythonGH-122072) Log call events in sys.setprofile when it is a method with a C function. (cherry picked from commit e91ef13) Co-authored-by: Tian Gao <[email protected]>
|
GH-122205 is a backport of this pull request to the 3.13 branch. |
|
GH-122206 is a backport of this pull request to the 3.12 branch. |
nohlson
pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
… with c function (pythonGH-122072) Log call events in sys.setprofile when it is a method with a C function.
nohlson
pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
… with c function (pythonGH-122072) Log call events in sys.setprofile when it is a method with a C function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
sys.setprofilelogs thec_returnevent, but notc_callevent, when the function is aPyMethodObjectthat points to aPyCFunction. This patch fixed that.