Update retroactive comments from GH-117741 (segfault in FutureIter_dealloc)
#121638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savannahostrowski
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
erlend-aasland
approved these changes
Jul 12, 2024
willingc
approved these changes
Jul 12, 2024
willingc
added
needs backport to 3.12
|
Thanks @savannahostrowski for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @savannahostrowski for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @savannahostrowski and @willingc, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 12, 2024
…Iter_dealloc`) (pythonGH-121638) Address comments (cherry picked from commit 65feded) Co-authored-by: Savannah Ostrowski <[email protected]>
|
GH-121642 is a backport of this pull request to the 3.13 branch. |
| @@ -1650,7 +1650,6 @@ FutureIter_dealloc(futureiterobject *it) | |||
| { | |||
| PyTypeObject *tp = Py_TYPE(it); | |||
|
|
|||
| // FutureIter is a heap type so any subclass must also be a heap type. | |||
| assert(_PyType_HasFeature(tp, Py_TPFLAGS_HEAPTYPE)); | |||
There was a problem hiding this comment.
Assert is redundant.
|
Post commit LGTM |
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…Iter_dealloc`) (pythonGH-121638) Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a couple of small comments left by @kumaraditya303 in #117741.