Skip to content

Add note about PYTHON_JIT environment variable to JIT README #121635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

savannahostrowski
Copy link
Member

Addressing a comment raised in the update to the PEP - python/peps#3850 (review). I've chosen to address the comment around the JIT environment variable in the JIT's README since I think that's maybe valuable to contributors and that file is linked from the PEP.

Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think you're missing a colon (and that's breaking the footnote):

@brandtbucher brandtbucher self-assigned this Jul 17, 2024
Co-authored-by: Brandt Bucher <[email protected]>
@brandtbucher brandtbucher added the needs backport to 3.13 bugs and security fixes label Jul 17, 2024
@brandtbucher brandtbucher merged commit f113c1a into python:main Jul 17, 2024
33 checks passed
@miss-islington-app
Copy link

Thanks @savannahostrowski for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 17, 2024

GH-121942 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 17, 2024
@savannahostrowski savannahostrowski deleted the update-jit-readme branch September 27, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants