Skip to content

gh-121533: Improve PyCell_[Get,Set] docs: mention the exceptions #121534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 9, 2024

Co-authored-by: Victor Stinner <[email protected]>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
Copy link
Member

vstinner commented Jul 9, 2024

The Lint job failed with a space issue.

@sobolevn
Copy link
Member Author

sobolevn commented Jul 9, 2024

@vstinner thanks a lot for the quick review!

@sobolevn sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 9, 2024
@sobolevn sobolevn merged commit 649d5b6 into python:main Jul 9, 2024
27 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2024
…ons (pythonGH-121534)

(cherry picked from commit 649d5b6)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2024

GH-121539 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 9, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2024
…ons (pythonGH-121534)

(cherry picked from commit 649d5b6)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@sobolevn
Copy link
Member Author

sobolevn commented Jul 9, 2024

I created two backports, because these functions are present on 3.12 and 3.13 and behave the same way.

@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2024

GH-121540 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jul 9, 2024
sobolevn added a commit that referenced this pull request Jul 9, 2024
…ions (GH-121534) (#121540)

gh-121533: Improve `PyCell_[Get,Set]` docs: mention the exceptions (GH-121534)
(cherry picked from commit 649d5b6)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
sobolevn added a commit that referenced this pull request Jul 9, 2024
…ions (GH-121534) (#121539)

gh-121533: Improve `PyCell_[Get,Set]` docs: mention the exceptions (GH-121534)
(cherry picked from commit 649d5b6)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants