bpo-33944: Add site.py debugging via PYTHONSITEDEBUG #12107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
reviewed
Mar 2, 2019
native-api
force-pushed
the
startup_debug
branch
from
8aeb858 to
afb7cf1
Compare
Co-Authored-By: Inada Naoki <[email protected]>
native-api
force-pushed
the
startup_debug
branch
from
afb7cf1 to
e26e98a
Compare
native-api
changed the title
tiran
requested changes
Jun 16, 2020
| @@ -74,6 +74,11 @@ | |||
| import builtins | |||
| import _sitebuiltins | |||
|
|
|||
|
|
|||
| if os.environ.get("PYTHONSITEDEBUG", ""): | |||
There was a problem hiding this comment.
Any PYTHON env var must be ignored when ignore environment is set.
Suggested change
| if os.environ.get("PYTHONSITEDEBUG", ""): | |
| if not sys.flags.ignore_environment and os.environ.get("PYTHONSITEDEBUG"): |
| at the start of the :mod:`site` module. | ||
| This is useful to diagnose issues in 3rd-party code that runs at startup. | ||
|
|
||
| .. versionadded:: 3.8 |
There was a problem hiding this comment.
Suggested change
| .. versionadded:: 3.8 | |
| .. versionadded:: 3.10 |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Closed as per #12107 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33944