[3.13] GH-119462: Enforce invariants of type versioning. Backport of GH-120731. #120748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove uses of Py_TPFLAGS_VALID_VERSION_TAG
|
@markshannon there are some compilation failures, apparently the type version cache doesn't exist the same way? |
iritkatriel
approved these changes
Jun 20, 2024
| Make sure that invariants of type versioning are maintained: | ||
| * Superclasses always have their version number assigned before subclasses | ||
| * The version tag is always zero if the tag is not valid. | ||
| * The version tag is always non-if the tag is valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120731