Skip to content

gh-120496: Use Critical section for rangeiter_next #120540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

gh-120496: Use Critical section for rangeiter_next #120540

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a81393
gh-120496: Use Critical section for rangeiter_next
corona10 Jun 15, 2024
2422b2f
Clean up header
corona10 Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Objects/rangeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include "Python.h"
#include "pycore_abstract.h" // _PyIndex_Check()
#include "pycore_ceval.h" // _PyEval_GetBuiltin()
#include "pycore_critical_section.h" // Py_BEGIN_CRITICAL_SECTION()
#include "pycore_long.h" // _PyLong_GetZero()
#include "pycore_modsupport.h" // _PyArg_NoKwnames()
#include "pycore_range.h"
Expand Down Expand Up @@ -813,16 +814,20 @@ PyTypeObject PyRange_Type = {
in the normal case, but possible for any numeric value.
*/


static PyObject *
rangeiter_next(_PyRangeIterObject *r)
{
PyObject *ret = NULL;
Py_BEGIN_CRITICAL_SECTION(r);
if (r->len > 0) {
long result = r->start;
r->start = result + r->step;
r->len--;
return PyLong_FromLong(result);
ret = PyLong_FromLong(result);
}
return NULL;
Py_END_CRITICAL_SECTION();
return ret;
}

static PyObject *
Expand Down