-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
gh-120417: Add #noqa to used imports in the stdlib #120421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
8347c30
19ceb4d
9b97f47
2189665
e31a9e2
7d93caa
13efcc9
648969c
0506006
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,7 +46,7 @@ | |
_collections_abc.MutableSequence.register(deque) | ||
|
||
try: | ||
from _collections import _deque_iterator | ||
from _collections import _deque_iterator # noqa | ||
except ImportError: | ||
pass | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @erlend-aasland @kumaraditya303: Do you know/recall why this symbol is exposed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, ======================================================================
ERROR: test_iterator_pickle (test.test_deque.TestBasic.test_iterator_pickle)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/alexw/dev/cpython/Lib/test/test_deque.py", line 640, in test_iterator_pickle
dump = pickle.dumps((itorg, orig), proto)
_pickle.PicklingError: Can't pickle <class 'collections._deque_iterator'>: attribute lookup _deque_iterator on collections failed
---------------------------------------------------------------------- There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, I added a comment. |
||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
from _collections_abc import * | ||
from _collections_abc import __all__ | ||
from _collections_abc import _CallableGenericAlias | ||
from _collections_abc import __all__ # noqa | ||
from _collections_abc import _CallableGenericAlias # noqa |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
try: | ||
from _datetime import * | ||
from _datetime import __doc__ | ||
from _datetime import __doc__ # noqa | ||
except ImportError: | ||
from _pydatetime import * | ||
from _pydatetime import __doc__ | ||
from _pydatetime import __doc__ # noqa | ||
|
||
__all__ = ("date", "datetime", "time", "timedelta", "timezone", "tzinfo", | ||
"MINYEAR", "MAXYEAR", "UTC") |
Uh oh!
There was an error while loading. Please reload this page.