Skip to content

gh-120155: Initialize variables in _tkinter.c #120156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024
Merged

gh-120155: Initialize variables in _tkinter.c #120156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Modules/_tkinter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1438,7 +1438,7 @@ Tkapp_Call(PyObject *selfptr, PyObject *args)
marshal the parameters to the interpreter thread. */
Tkapp_CallEvent *ev;
Tcl_Condition cond = NULL;
PyObject *exc;
PyObject *exc = NULL; // init to make static analyzers happy
if (!WaitForMainloop(self))
return NULL;
ev = (Tkapp_CallEvent*)attemptckalloc(sizeof(Tkapp_CallEvent));
Expand Down Expand Up @@ -1712,7 +1712,8 @@ var_invoke(EventFunc func, PyObject *selfptr, PyObject *args, int flags)
TkappObject *self = (TkappObject*)selfptr;
if (self->threaded && self->thread_id != Tcl_GetCurrentThread()) {
VarEvent *ev;
PyObject *res, *exc;
// init 'res' and 'exc' to make static analyzers happy
PyObject *res = NULL, *exc = NULL;
Tcl_Condition cond = NULL;

/* The current thread is not the interpreter thread. Marshal
Expand Down Expand Up @@ -2413,6 +2414,8 @@ _tkinter_tkapp_createcommand_impl(TkappObject *self, const char *name,
data->self = self;
data->func = Py_NewRef(func);
if (self->threaded && self->thread_id != Tcl_GetCurrentThread()) {
err = 0; // init to make static analyzers happy

Tcl_Condition cond = NULL;
CommandEvent *ev = (CommandEvent*)attemptckalloc(sizeof(CommandEvent));
if (ev == NULL) {
Expand Down Expand Up @@ -2468,6 +2471,8 @@ _tkinter_tkapp_deletecommand_impl(TkappObject *self, const char *name)
TRACE(self, ("((sss))", "rename", name, ""));

if (self->threaded && self->thread_id != Tcl_GetCurrentThread()) {
err = 0; // init to make static analyzers happy

Tcl_Condition cond = NULL;
CommandEvent *ev;
ev = (CommandEvent*)attemptckalloc(sizeof(CommandEvent));
Expand Down