Skip to content

gh-120121: Add InvalidStateError to concurrent.futures.__all__ #120123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 8, 2024

Conversation

aisk
Copy link
Contributor

@aisk aisk commented Jun 5, 2024

@aisk aisk added 3.12 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed 3.12 only security fixes labels Jun 5, 2024
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's wait a bit for someone else with a better asyncio expertise than me to merge it!

@sobolevn sobolevn requested a review from willingc June 6, 2024 08:37
@sobolevn
Copy link
Member

sobolevn commented Jun 6, 2024

@willingc you are one of the few active asyncio codeowners, can you please take a look? Do we need this error to be in __all__?

@kumaraditya303 kumaraditya303 merged commit 5d59b87 into python:main Jun 8, 2024
35 checks passed
@miss-islington-app
Copy link

Thanks @aisk for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2024
…ythonGH-120123)

(cherry picked from commit 5d59b87)

Co-authored-by: AN Long <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 8, 2024

GH-120273 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 8, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2024
…ythonGH-120123)

(cherry picked from commit 5d59b87)

Co-authored-by: AN Long <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 8, 2024

GH-120274 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jun 8, 2024
@aisk aisk deleted the concurrent-futures-all branch June 8, 2024 16:12
kumaraditya303 pushed a commit that referenced this pull request Jun 8, 2024
…GH-120123) (#120274)

gh-120121: Add InvalidStateError to concurrent.futures.__all__ (GH-120123)
(cherry picked from commit 5d59b87)

Co-authored-by: AN Long <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request Jun 8, 2024
…GH-120123) (#120273)

gh-120121: Add InvalidStateError to concurrent.futures.__all__ (GH-120123)
(cherry picked from commit 5d59b87)

Co-authored-by: AN Long <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants