-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-115773: Use the right variable name based on the field we are trying read #118591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
abhinav-upadhyay
commented
May 5, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Exercise the debug structs placed in PyRuntime #115773
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Hello! |
Okay, no issues! However, I would just add that having the wrong variable name in that place and fixing its name to reflect the correct intention of its use is not as cosmetic as fixing a typo in the name. The person reading that is going to be left confused. I'm not sure who the author of that module is but I'm pretty sure they would fix it themselves if they noticed it. |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
I'm reopening this as even if this is changing just a variable name this is a bit of a "bug" as the variable name its actually misleading (as it doesn't contain what it says it contains). |
…ing read (python#118591) Co-authored-by: Pablo Galindo Salgado <[email protected]>