Skip to content

gh-115773: Use the right variable name based on the field we are trying read #118591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2024

Conversation

abhinav-upadhyay
Copy link
Contributor

@abhinav-upadhyay abhinav-upadhyay commented May 5, 2024

@ghost
Copy link

ghost commented May 5, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label May 5, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 5, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Eclips4
Copy link
Member

Eclips4 commented May 5, 2024

Hello!
Sorry, but CPython as a rule does not accept cosmetic PRs.
I'm going to close this one.

@Eclips4 Eclips4 closed this May 5, 2024
@abhinav-upadhyay
Copy link
Contributor Author

Okay, no issues!

However, I would just add that having the wrong variable name in that place and fixing its name to reflect the correct intention of its use is not as cosmetic as fixing a typo in the name. The person reading that is going to be left confused.

I'm not sure who the author of that module is but I'm pretty sure they would fix it themselves if they noticed it.

@pablogsal pablogsal reopened this May 7, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 7, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@pablogsal
Copy link
Member

I'm reopening this as even if this is changing just a variable name this is a bit of a "bug" as the variable name its actually misleading (as it doesn't contain what it says it contains).

@pablogsal pablogsal changed the title Use the right variable name based on the field we are trying read bpo-115773: Use the right variable name based on the field we are trying read May 7, 2024
@pablogsal pablogsal enabled auto-merge (squash) May 7, 2024 13:45
@pablogsal pablogsal changed the title bpo-115773: Use the right variable name based on the field we are trying read gh-115773: Use the right variable name based on the field we are trying read May 7, 2024
@pablogsal pablogsal merged commit 26bab42 into python:main May 7, 2024
34 checks passed
@abhinav-upadhyay abhinav-upadhyay deleted the fix-variable-name branch May 8, 2024 05:52
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants