gh-117975: Ensure flush level is checked when configuring a logging MemoryHandler. #117976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 17, 2024
…ging MemoryHandler. (pythonGH-117976) (cherry picked from commit 6d0bb43) Co-authored-by: Vinay Sajip <[email protected]>
|
GH-117986 is a backport of this pull request to the 3.12 branch. |
vsajip
pushed a commit
that referenced
this pull request
Apr 17, 2024
|
python3.11 still broken in cpython/Lib/logging/handlers.py Line 1368 in 8b275e7 File "/usr/lib/python3.11/logging/__init__.py", line 978, in handle
self.emit(record)
TypeError: '>=' not supported between instances of 'int' and 'str' |
|
3.11 is in security-fix-only mode, so this change will not be backported to that version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #117963, which led to creating the issue and this PR.
dictConfig()does not convert it to a numeric value. #117975