Skip to content

gh-117618: Make package.module searchable for breakpoints and clean up docs #117619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 30, 2024
Merged

gh-117618: Make package.module searchable for breakpoints and clean up docs #117619

merged 9 commits into from
Apr 30, 2024

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Apr 8, 2024 •
edited by github-actions bot
Loading

  • Make package.module searchable by normalizing filename first in lookupmodule.
  • Clean up the code in lookupmodule.
  • Clarify the docs for break. Re-structured to make it more reasonable.

📚 Documentation preview 📚: https://cpython-previews--117619.org.readthedocs.build/

@bedevere-app bedevere-app bot mentioned this pull request Apr 8, 2024
Closed
@gaogaotiantian
Copy link
Member Author

Hi @iritkatriel , let me know if you need more explanation for this PR. The motivation is in the linked issue.

@gaogaotiantian
Copy link
Member Author

Hey @iritkatriel , a friendly ping here, as it's getting closer to the feature freeze. I think this makes the break command more consistent and it would be nice to have it in 3.13 instead of 3.14.

iritkatriel
iritkatriel reviewed Apr 30, 2024
View reviewed changes
Misc/NEWS.d/next/Library/2024-04-08-03-23-22.gh-issue-117618.-4DCUw.rst Outdated
@@ -0,0 +1 @@
Support ``package.module`` as ``filename`` for ``break`` command
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention pdb

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the current version better?

iritkatriel
iritkatriel reviewed Apr 30, 2024
View reviewed changes
@gaogaotiantian @iritkatriel
Update docs
009fa1a 
Co-authored-by: Irit Katriel <[email protected]>
@gaogaotiantian
Copy link
Member Author

Thanks for the doc fix!

@iritkatriel iritkatriel enabled auto-merge (squash) April 30, 2024 17:55
@iritkatriel iritkatriel merged commit d7ac427 into python:main Apr 30, 2024
@gaogaotiantian gaogaotiantian deleted the pdb-break-args branch April 30, 2024 19:08
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@gaogaotiantian @SonicField
pythongh-117618: Make package.module searchable for breakpoints and c…
3fc1425 
…lean up docs (python#117619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaogaotiantian @iritkatriel