Skip to content

gh-117521: Improve typing.TypeGuard docstring #117522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Apr 3, 2024

The example is taken from the online documentation, https://docs.python.org/3.12/library/typing.html#typing.TypeGuard. Unlike the previous example, it actually uses TypeGuard.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement. The previous version of this example was less clear for me.

@JelleZijlstra JelleZijlstra merged commit b32789c into python:main Apr 4, 2024
@miss-islington-app
Copy link

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@JelleZijlstra JelleZijlstra deleted the typeguarddocstr branch April 4, 2024 10:39
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 4, 2024
@bedevere-app
Copy link

bedevere-app bot commented Apr 4, 2024

GH-117538 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 4, 2024
JelleZijlstra added a commit that referenced this pull request Apr 4, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@JelleZijlstra JelleZijlstra restored the typeguarddocstr branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants