Skip to content

gh-117084: Fix zip extraction bug #117085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

gh-117084: Fix zip extraction bug #117085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7914efe
gh-117084: Fix zip extraction bug
fliiiix Mar 20, 2024
4430b29
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 20, 2024
6360789
Update Misc/NEWS.d/next/Core and Builtins/2024-03-20-15-54-25.gh-issu…
fliiiix Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/zipfile/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ def from_file(cls, filename, arcname=None, *, strict_timestamps=True):

def is_dir(self):
"""Return True if this archive member is a directory."""
return self.filename.endswith('/')
return self.filename.endswith('/') or self.filename.endswith('\\')


# ZIP encryption uses the CRC32 one-byte primitive for scrambling some
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2024-03-20-15-54-25.gh-issue-117084.uj1NbR.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix extraction of zip files created on Windows