-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-116600: [Enum] fix global Flag repr #116615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ethanfurman
merged 4 commits into
python:main
from
ethanfurman:enum-fix_global_flag_repr
Mar 11, 2024
Merged
gh-116600: [Enum] fix global Flag repr #116615
ethanfurman
merged 4 commits into
python:main
from
ethanfurman:enum-fix_global_flag_repr
Mar 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ethanfurman
commented
Mar 11, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Pydoc fails for test.test_enum #116600
Eclips4
reviewed
Mar 11, 2024
Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst
Outdated
Show resolved
Hide resolved
serhiy-storchaka
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for a NEWS entry style nitpick.
Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst
Outdated
Show resolved
Hide resolved
…cNBy_.rst Co-authored-by: Kirill Podoprigora <[email protected]>
ethanfurman
commented
Mar 11, 2024
Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst
Outdated
Show resolved
Hide resolved
Eclips4
reviewed
Mar 11, 2024
Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst
Outdated
Show resolved
Hide resolved
Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 11, 2024
* and fix global flag repr * Update Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst (cherry picked from commit 06e29a2) Co-authored-by: Ethan Furman <[email protected]> Co-authored-by: Kirill Podoprigora <[email protected]>
GH-116629 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 11, 2024
* and fix global flag repr * Update Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst (cherry picked from commit 06e29a2) Co-authored-by: Ethan Furman <[email protected]> Co-authored-by: Kirill Podoprigora <[email protected]>
GH-116630 is a backport of this pull request to the 3.11 branch. |
ethanfurman
added a commit
that referenced
this pull request
Mar 12, 2024
* and fix global flag repr (cherry picked from commit 06e29a2) Co-authored-by: Ethan Furman <[email protected]> Co-authored-by: Kirill Podoprigora <[email protected]>
ethanfurman
added a commit
that referenced
this pull request
Mar 12, 2024
* and fix global flag repr (cherry picked from commit 06e29a2) Co-authored-by: Ethan Furman <[email protected]> Co-authored-by: Kirill Podoprigora <[email protected]>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
* and fix global flag repr * Update Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst Co-authored-by: Kirill Podoprigora <[email protected]>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
* and fix global flag repr * Update Misc/NEWS.d/next/Library/2024-03-11-12-11-10.gh-issue-116600.FcNBy_.rst Co-authored-by: Kirill Podoprigora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.