gh-112925: Fix error in example of datetime.time.fromisoformat and add doctest marker
#112931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
docs
pganssle
approved these changes
Dec 12, 2023
| @@ -1799,6 +1799,8 @@ Other constructor: | |||
|
|
|||
| Examples:: | |||
|
|
|||
| .. doctest:: | |||
There was a problem hiding this comment.
Interesting, I didn't realize that anything actually was running these tests.
pganssle
added
needs backport to 3.11
thesayfulla
approved these changes
Dec 23, 2023
serhiy-storchaka
approved these changes
Dec 23, 2023
|
Thanks @F-park for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-113427 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 23, 2023
…` and add doctest marker (pythonGH-112931) (cherry picked from commit bdc8d66) Co-authored-by: F-park <[email protected]>
|
GH-113428 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 23, 2023
…` and add doctest marker (pythonGH-112931) (cherry picked from commit bdc8d66) Co-authored-by: F-park <[email protected]>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 23, 2023
…t` and add doctest marker (GH-112931) (GH-113427) (cherry picked from commit bdc8d66) Co-authored-by: F-park <[email protected]>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 23, 2023
…t` and add doctest marker (GH-112931) (GH-113428) (cherry picked from commit bdc8d66) Co-authored-by: F-park <[email protected]>
ryan-duve
pushed a commit
to ryan-duve/cpython
that referenced
this pull request
Dec 26, 2023
…` and add doctest marker (pythonGH-112931)
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…` and add doctest marker (pythonGH-112931)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…` and add doctest marker (pythonGH-112931)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…` and add doctest marker (pythonGH-112931)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datetime.time.fromisoformat#112925📚 Documentation preview 📚: https://cpython-previews--112931.org.readthedocs.build/