Skip to content

gh-112535: Add comment for ppc32/64 registers #112746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2023
Merged

gh-112535: Add comment for ppc32/64 registers #112746

merged 2 commits into from
Dec 5, 2023

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Dec 5, 2023 •
edited by bedevere-app bot
Loading

@corona10 corona10 requested a review from vstinner December 5, 2023 09:38
@bedevere-app bedevere-app bot mentioned this pull request Dec 5, 2023
Closed
@corona10
Copy link
Member Author

corona10 commented Dec 5, 2023

Reference:
32bit: https://github.com/ryanarn/powerabi
64bit: https://ftp.libre-soc.org/PPC-elf64abi-1.4.1.txt

vstinner
vstinner reviewed Dec 5, 2023
View reviewed changes
vstinner
vstinner approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for these adding these comments :-)

@corona10 corona10 merged commit 5aa317e into python:main Dec 5, 2023
@corona10 corona10 deleted the gh-112535-powerpc-comments branch December 5, 2023 10:44
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@corona10 @aisk
pythongh-112535: Add comment for ppc32/64 registers (pythongh-112746)
06544bb
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@corona10 @Glyphack
pythongh-112535: Add comment for ppc32/64 registers (pythongh-112746)
4e54665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corona10 @vstinner