[3.12] gh-109413: libregrtest: enable mypy's --strict-optional check on most files (#112586)
#112602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on most files (python#112586) Co-authored-by: Victor Stinner <[email protected]>
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-112603 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 1, 2023
…` check on most files (pythonGH-112586) (pythonGH-112602) pythongh-109413: libregrtest: enable mypy's `--strict-optional` check on most files (pythonGH-112586) (cherry picked from commit 36dbebe) Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
AlexWaygood
added a commit
that referenced
this pull request
Dec 1, 2023
…l` check on most files (GH-112586) (GH-112602) (#112603) [3.12] gh-109413: libregrtest: enable mypy's `--strict-optional` check on most files (GH-112586) (GH-112602) gh-109413: libregrtest: enable mypy's `--strict-optional` check on most files (GH-112586) (cherry picked from commit 36dbebe) Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry-picked from commit 70a38ff )
Note: I'm deliberately backporting the entire mypy config file to the 3.12 branch, even though we don't run mypy on
libregrteston the 3.12 branch. Having the config file exist on this branch will make future backports easier, even if the file is never actually used on this branch.