Remove bogus annotations from the descriptor howto guide #112349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
approved these changes
Nov 23, 2023
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 23, 2023
…2349) (cherry picked from commit d9fc152) Co-authored-by: Raymond Hettinger <[email protected]>
|
GH-112350 is a backport of this pull request to the 3.11 branch. |
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
GH-112352 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 23, 2023
…2349) (cherry picked from commit d9fc152) Co-authored-by: Raymond Hettinger <[email protected]>
AlexWaygood
pushed a commit
that referenced
this pull request
Nov 23, 2023
…12349) (#112352) Remove bogus annotations from the descriptor howto guide (GH-112349) (cherry picked from commit d9fc152) Co-authored-by: Raymond Hettinger <[email protected]>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are distracting and add no value. We don't even use them in the main docs. Knowing type annotations is not a prerequisite for reading this guide. These lines aren't
defstatements so the the->notation makes no sense and is out of context. Also-> valueisn't even a valid type. It is just noise.📚 Documentation preview 📚: https://cpython-previews--112349.org.readthedocs.build/