[3.7] Removed dangling since Python at the end of library/xml.rst. (GH-11201)
#11231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nGH-11201) (cherry picked from commit 82d7355) Co-authored-by: Jules Lasne (jlasne) <[email protected]>
bedevere-bot
added
skip issue
skip news
docs
|
@Seluj78 and @serhiy-storchaka: Status check is done, and it's a success ✅ . |
eamanu
approved these changes
Dec 19, 2018
Seluj78
approved these changes
Dec 19, 2018
Doc/library/xml.rst
Outdated
| @@ -75,8 +75,8 @@ decompression bomb Safe Safe Safe S | |||
| 2. :mod:`xml.dom.minidom` doesn't expand external entities and simply returns | |||
| the unexpanded entity verbatim. | |||
| 3. :mod:`xmlrpclib` doesn't expand external entities and omits them. | |||
| 4. Since Python 3.8.0, external general entities are no longer processed by | |||
| default since Python. | |||
| 4. Since Python 3.8, external general entities are no longer processed by | |||
There was a problem hiding this comment.
Should be 3.7.1 instead of 3.8. And docs for 3.8 should refer to 3.7.1 too, because there were no vulnerable releases between 3.7.1 and 3.8.0.
There was a problem hiding this comment.
Suggested change
| 4. Since Python 3.8, external general entities are no longer processed by | |
| 4. Since Python 3.7.1, external general entities are no longer processed by |
|
@Seluj78 and @serhiy-storchaka: Status check is done, and it's a success ✅ . |
serhiy-storchaka
approved these changes
Dec 20, 2018
ned-deily
pushed a commit
to ned-deily/cpython
that referenced
this pull request
Dec 23, 2018
…ythonGH-11201) (pythonGH-11231) (cherry picked from commit 82d7355) Co-authored-by: Jules Lasne (jlasne) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 82d7355)
Co-authored-by: Jules Lasne (jlasne) [email protected]