bpo-35499: Fix LDFLAGS in "make build_all_generate_profile" #11219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"make build_all_generate_profile" doesn't add PGO_PROF_GEN_FLAG flags to LDFLAGS anymore. Remove also LDFLAGS="$(LDFLAGS)" from "make profile-opt".
|
cc @stratakis |
|
responded on the issue, the linker needs the pgo flags for the profile generation build. it is only used for the instrumented build, not the final build. |
|
This PR simply breaks PGO compilation: https://bugs.python.org/issue35499#msg332134 I close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"make build_all_generate_profile" doesn't add PGO_PROF_GEN_FLAG flags
to LDFLAGS anymore.
Remove also LDFLAGS="$(LDFLAGS)" from "make profile-opt".
https://bugs.python.org/issue35499