Skip to content

gh-111789: Use PyDict_GetItemRef() in sqlite #111829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 10, 2023
Merged

gh-111789: Use PyDict_GetItemRef() in sqlite #111829

merged 4 commits into from
Nov 10, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 7, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 7, 2023
Closed
serhiy-storchaka
serhiy-storchaka commented Nov 7, 2023
View reviewed changes
Modules/_sqlite/cursor.c Outdated
current_param = PyObject_GetItem(parameters, binding_name_obj);
}
PyObject *current_param;
(void)PyMapping_GetOptionalItem(parameters, binding_name_obj, &current_param);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyMapping_GetOptionalItem() includes a special case for dict, so there is no performance loss.

@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review November 8, 2023 17:47
erlend-aasland
erlend-aasland approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; the resulting code is cleaner, thus positively affecting readability and maintainability.

@serhiy-storchaka
Copy link
Member Author

It can be even more simplified if use PyMapping_GetOptionalItemString().

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) November 10, 2023 20:29
@serhiy-storchaka serhiy-storchaka merged commit afac3c9 into python:main Nov 10, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-111789: Simplify the sqlite code (pythonGH-111829)
7a6c010 
Use new C API functions PyDict_GetItemRef() and
PyMapping_GetOptionalItemString().
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-111789: Simplify the sqlite code (pythonGH-111829)
30e1e40 
Use new C API functions PyDict_GetItemRef() and
PyMapping_GetOptionalItemString().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @erlend-aasland