Skip to content

[3.7] bpo-35499: make profile-opt don't override CFLAGS_NODIST (GH-11164) #11179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2018
Merged

[3.7] bpo-35499: make profile-opt don't override CFLAGS_NODIST (GH-11164) #11179

merged 1 commit into from
Dec 16, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 16, 2018 •
edited by bedevere-bot
Loading

"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It
now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,
existing CFLAGS_NODIST flags are kept.
(cherry picked from commit 640ed52)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue35499

@vstinner @miss-islington
bpo-35499: make profile-opt don't override CFLAGS_NODIST (pythonGH-11164
69adf6b 
)

"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It
now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,
existing CFLAGS_NODIST flags are kept.
(cherry picked from commit 640ed52)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Dec 16, 2018
Merged
vstinner
vstinner approved these changes Dec 16, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Dec 16, 2018 •
edited by bedevere-bot
Loading

Sorry, I can't merge this PR. Reason: `Invalid request.

For 'properties/commit_message', ["bpo-35499: make profile-opt don't override CFLAGS_NODIST (GH-11164)", "", ""make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It", "now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,", "existing CFLAGS_NODIST flags are kept.", "(cherry picked from commit 640ed52)", "", "Co-authored-by: Victor Stinner [email protected]"] is not a string.`.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Dec 16, 2018 •
edited by bedevere-bot
Loading

Sorry, I can't merge this PR. Reason: `Invalid request.

For 'properties/commit_message', ["bpo-35499: make profile-opt don't override CFLAGS_NODIST (GH-11164)", "", ""make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It", "now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,", "existing CFLAGS_NODIST flags are kept.", "(cherry picked from commit 640ed52)", "", "Co-authored-by: Victor Stinner [email protected]"] is not a string.`.

@vstinner vstinner merged commit 9a47585 into python:3.7 Dec 16, 2018
@miss-islington miss-islington deleted the backport-640ed52-3.7 branch December 16, 2018 22:24
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Dec 23, 2018
@miss-islington @vstinner @ned-deily
bpo-35499: make profile-opt don't override CFLAGS_NODIST (pythonGH-11164
7e4e4bd 
) (pythonGH-11179)

"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It
now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,
existing CFLAGS_NODIST flags are kept.
(cherry picked from commit 640ed52)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot