Skip to content

gh-110905: [Enum] minor fixes and cleanup #110906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 16, 2023
Merged

gh-110905: [Enum] minor fixes and cleanup #110906

merged 4 commits into from
Oct 16, 2023

Conversation

eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Oct 15, 2023 •
edited
Loading

  • Fix enum._is_private (bug + anti-bug) for triple underscore names
  • Rewrite _is_sunder check in the same style as _is_private
  • Remove unused variable blanks
  • Update docstring

@bedevere-app bedevere-app bot mentioned this pull request Oct 15, 2023
Closed
@ethanfurman ethanfurman changed the title gh-110905: fix enum._is_private for triple underscore names gh-110905: [Enum] minor fixes and cleanup Oct 16, 2023
ethanfurman
ethanfurman requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple changes and we're good to go!

@bedevere-app
Copy link

bedevere-app bot commented Oct 16, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ethanfurman ethanfurman self-assigned this Oct 16, 2023
eendebakpt
eendebakpt commented Oct 16, 2023
View reviewed changes
@ethanfurman ethanfurman merged commit a77180e into python:main Oct 16, 2023
@sunmy2019
Copy link
Member

@ethanfurman shall we backport this?

@sunmy2019 sunmy2019 added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 18, 2023
@miss-islington-app
Copy link

Thanks @eendebakpt for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @eendebakpt for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 18, 2023
@eendebakpt @miss-islington
pythongh-110905: [Enum] minor fixes and cleanup (pythonGH-110906)
6a52ab1 
(cherry picked from commit a77180e)

Co-authored-by: Pieter Eendebak <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 18, 2023
@eendebakpt @miss-islington
pythongh-110905: [Enum] minor fixes and cleanup (pythonGH-110906)
6a8033a 
(cherry picked from commit a77180e)

Co-authored-by: Pieter Eendebak <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 18, 2023

GH-111042 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 18, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 18, 2023

GH-111043 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 18, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@eendebakpt @aisk
pythongh-110905: [Enum] minor fixes and cleanup (pythonGH-110906)
0aa2c63
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@eendebakpt @Glyphack
pythongh-110905: [Enum] minor fixes and cleanup (pythonGH-110906)
2c7b732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees

@ethanfurman ethanfurman

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eendebakpt @sunmy2019 @ethanfurman