gh-107450: Check for overflow in the tokenizer and fix overflow test #110832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lysnikolaou
commented
Oct 13, 2023
•
lysnikolaou
commented
- Issue: string length overflows to negative when executing #107450
2 tasks
lysnikolaou
added
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @lysnikolaou for commit 3036fad 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
… test Co-authored-by: Filipe Laíns <[email protected]>
lysnikolaou
force-pushed
the
overflow-error-col-offset
branch
from
3036fad to
16d508d
Compare
pablogsal
reviewed
Oct 13, 2023
lysnikolaou
force-pushed
the
overflow-error-col-offset
branch
from
1f94480 to
f20b95f
Compare
|
@serhiy-storchaka Thanks a lot for the reviews! I've addressed all comments. |
serhiy-storchaka
approved these changes
Oct 16, 2023
|
Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @lysnikolaou, I could not cleanly backport this to |
|
Sorry, @lysnikolaou, I could not cleanly backport this to |
|
GH-110931 is a backport of this pull request to the 3.12 branch. |
lysnikolaou
added a commit
to lysnikolaou/cpython
that referenced
this pull request
Oct 16, 2023
…verflow test (pythonGH-110832) (cherry picked from commit a1ac559) Co-authored-by: Lysandros Nikolaou <[email protected]> Co-authored-by: Filipe Laíns <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-110939 is a backport of this pull request to the 3.11 branch. |
lysnikolaou
added a commit
to lysnikolaou/cpython
that referenced
this pull request
Oct 16, 2023
…verflow test (pythonGH-110832) (cherry picked from commit a1ac559) Co-authored-by: Lysandros Nikolaou <[email protected]> Co-authored-by: Filipe Laíns <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
lysnikolaou
added a commit
that referenced
this pull request
Oct 16, 2023
…w test (GH-110832) (#110931) (cherry picked from commit a1ac559) Co-authored-by: Lysandros Nikolaou <[email protected]> Co-authored-by: Filipe Laíns <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
vstinner
pushed a commit
that referenced
this pull request
Oct 17, 2023
…w test (GH-110832) (#110939) (cherry picked from commit a1ac559) Co-authored-by: Filipe Laíns <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
… test (python#110832) Co-authored-by: Filipe Laíns <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
… test (python#110832) Co-authored-by: Filipe Laíns <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.