GH-110796: fix intermittent test failure in test_current_exceptions #110797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Signed-off-by: Filipe Laíns <[email protected]>
FFY00
added
skip news
and removed
tests
|
@jd, I know it has been a while, but as the original author, could you have a look? Did I missing something, or is my interpretation sane? Thanks! |
FFY00
commented
Oct 13, 2023
| if leave_g.wait(timeout=support.LONG_TIMEOUT): | ||
| break | ||
|
|
||
| t = threading.Thread(target=f123) | ||
| t.start() | ||
| entered_g.wait() | ||
| g_raised.wait(timeout=support.LONG_TIMEOUT) |
There was a problem hiding this comment.
Also added a timeout here, as if an unexpected exception is raised in the thread, the event will never be set, and we will deadlock.
|
The Windows failure is GH-110800. |
jd
suggested changes
Oct 13, 2023
Signed-off-by: Filipe Laíns <[email protected]>
|
Thanks! I forgot that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_sys.SysModuleTest.test_current_exceptions#110796