Skip to content

gh-109693: Update pycore_interp.h to use pyatomic.h #110604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

gh-109693: Update pycore_interp.h to use pyatomic.h #110604

merged 1 commit into from
Oct 10, 2023

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Oct 10, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 10, 2023
Closed
vstinner
vstinner approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's good to put a typename to the pointer, even if _Py_atomic_load_ptr_relaxed() still requires a cast.

@corona10 corona10 merged commit 5bc1b7f into python:main Oct 10, 2023
@corona10 corona10 deleted the gh-109693-interp branch October 10, 2023 14:17
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@corona10 @Glyphack
pythongh-109693: Update pycore_interp.h to use pyatomic.h (python#110604
431c923 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@colesbury colesbury Awaiting requested review from colesbury

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corona10 @vstinner