Skip to content

gh-109832: concurrent.futures test_deadlock restores sys.stderr #109887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2023
Merged

gh-109832: concurrent.futures test_deadlock restores sys.stderr #109887

merged 1 commit into from
Sep 26, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 26, 2023 •
edited by bedevere-app bot
Loading

test_error_at_task_unpickle() and
test_error_during_result_unpickle_in_result_handler() now restore sys.stderr which is overriden by _raise_error_ignore_stderr().

@vstinner vstinner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 26, 2023
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Sep 26, 2023
@bedevere-app bedevere-app bot mentioned this pull request Sep 26, 2023
Closed
@vstinner
pythongh-109832: concurrent.futures test_deadlock restores sys.stderr
236ac3d 
test_error_at_task_unpickle() and
test_error_during_result_unpickle_in_result_handler() now restore
sys.stderr which is overriden by _raise_error_ignore_stderr().
@vstinner
Copy link
Member Author

Windows x64 failed:

ERROR: test_CTRL_BREAK_EVENT (test.test_os.Win32KillTests.test_CTRL_BREAK_EVENT)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_os.py", line 2616, in test_CTRL_BREAK_EVENT
    self._kill_with_event(signal.CTRL_BREAK_EVENT, "CTRL_BREAK_EVENT")
  File "D:\a\cpython\cpython\Lib\test\test_os.py", line 2591, in _kill_with_event
    os.kill(proc.pid, signal.SIGINT)
PermissionError: [WinError 5] Access is denied

Test passed when re-run:

test_CTRL_BREAK_EVENT (test.test_os.Win32KillTests.test_CTRL_BREAK_EVENT) ... ok

@vstinner
Copy link
Member Author

Windows x64 failed: ERROR: test_CTRL_BREAK_EVENT (test.test_os.Win32KillTests.test_CTRL_BREAK_EVENT)

I created issue gh-109888 for this failure.

@vstinner vstinner merged commit 2897142 into python:main Sep 26, 2023
@vstinner vstinner deleted the cf_restore_stderr branch September 26, 2023 10:43
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2023
@vstinner @miss-islington
pythongh-109832: concurrent.futures test_deadlock restores sys.stderr (…
8148868 
…pythonGH-109887)

test_error_at_task_unpickle() and
test_error_during_result_unpickle_in_result_handler() now restore
sys.stderr which is overriden by _raise_error_ignore_stderr().
(cherry picked from commit 2897142)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 26, 2023

GH-109892 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 26, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2023
@vstinner @miss-islington
pythongh-109832: concurrent.futures test_deadlock restores sys.stderr (…
1e17c2d 
…pythonGH-109887)

test_error_at_task_unpickle() and
test_error_during_result_unpickle_in_result_handler() now restore
sys.stderr which is overriden by _raise_error_ignore_stderr().
(cherry picked from commit 2897142)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 26, 2023

GH-109893 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 26, 2023
vstinner added a commit that referenced this pull request Sep 26, 2023
@miss-islington @vstinner
[3.11] gh-109832: concurrent.futures test_deadlock restores sys.stderr (
bda6949 
GH-109887) (#109893)

gh-109832: concurrent.futures test_deadlock restores sys.stderr (GH-109887)

test_error_at_task_unpickle() and
test_error_during_result_unpickle_in_result_handler() now restore
sys.stderr which is overriden by _raise_error_ignore_stderr().
(cherry picked from commit 2897142)

Co-authored-by: Victor Stinner <[email protected]>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@vstinner @csm10495
pythongh-109832: concurrent.futures test_deadlock restores sys.stderr (…
a9ed4b2 
…python#109887)

test_error_at_task_unpickle() and
test_error_during_result_unpickle_in_result_handler() now restore
sys.stderr which is overriden by _raise_error_ignore_stderr().
Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
@miss-islington @vstinner
[3.12] gh-109832: concurrent.futures test_deadlock restores sys.stderr (
84f9da9 
GH-109887) (#109892)

gh-109832: concurrent.futures test_deadlock restores sys.stderr (GH-109887)

test_error_at_task_unpickle() and
test_error_during_result_unpickle_in_result_handler() now restore
sys.stderr which is overriden by _raise_error_ignore_stderr().
(cherry picked from commit 2897142)

Co-authored-by: Victor Stinner <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-109832: concurrent.futures test_deadlock restores sys.stderr (…
334a7bb 
…python#109887)

test_error_at_task_unpickle() and
test_error_during_result_unpickle_in_result_handler() now restore
sys.stderr which is overriden by _raise_error_ignore_stderr().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @miss-islington