Skip to content

[3.12] gh-108948: Skip test_tarfile.test_modes() on EFTYPE error (#109697) #109698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2023
Merged

[3.12] gh-108948: Skip test_tarfile.test_modes() on EFTYPE error (#109697) #109698

merged 1 commit into from
Oct 2, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 21, 2023 •
edited by bedevere-app bot
Loading

On FreeBSD, regular users cannot set the sticky bit. Skip the test if chmod() fails with EFTYPE error.

(cherry picked from commit 26e06ad)

@vstinner
pythongh-108948: Skip test_tarfile.test_modes() on EFTYPE error (pyth…
71a615d 
…on#109697)

On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.

(cherry picked from commit 26e06ad)
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Sep 21, 2023
@vstinner vstinner added skip news and removed tests Tests in the Lib/test dir awaiting review labels Sep 21, 2023
This was referenced Sep 21, 2023
Closed
Merged
@vstinner
Copy link
Member Author

!buildbot AMD64 FreeBSD

@bedevere-bot
Copy link

The regex {builder_filter!r} did not match any buildbot builder

@vstinner vstinner mentioned this pull request Sep 21, 2023
Merged
@vstinner
Copy link
Member Author

The regex {builder_filter!r} did not match any buildbot builder

I knew it in advance :-) It was just to test my fix python/buildmaster-config#390 :-)

@vstinner
Copy link
Member Author

I tested this change manually on my FreeBSD VM: it works as expected.

@JelleZijlstra
Copy link
Member

@vstinner seems like there's a missing f on an f-string in the previous message from Bedevere, do you know if that's already fixed or tracked?

@JelleZijlstra
Copy link
Member

Ah, seems like python/buildmaster-config@69e9ee1 fixed it.

@vstinner
Copy link
Member Author

!buildbot AMD64 FreeBSD

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 71a615d 🤖

The command will test the builders whose names match following regular expression: AMD64 FreeBSD

The builders matched are:

  • AMD64 FreeBSD PR

@vstinner
Copy link
Member Author

AMD64 FreeBSD buildbot joined the club of STABLE buildbots and so can now used on GitHub PRs with !buildbot AMD64 FreeBSD comment!

@vstinner
Copy link
Member Author

buildbot/AMD64 FreeBSD PR — Build done.

Good, tests pass.

Total test files: run=479/483 skipped=16 resource_denied=4
Result: SUCCESS

Currently, FreeBSD 3.12 buildbot fails because of test_tarfile: https://buildbot.python.org/all/#/builders/1220

@Yhg1s Yhg1s merged commit 84ef145 into python:3.12 Oct 2, 2023
@vstinner vstinner deleted the test_tarfile_modes_312 branch January 14, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @bedevere-bot @JelleZijlstra @Yhg1s