-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-108455: Run mypy
on Tools/peg_generator
#108456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(Resolved conflict) |
@@ -35,6 +35,7 @@ | |||
issoftkeyword = frozenset(softkwlist).__contains__ | |||
'''.lstrip() | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is black
reformat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I'm slightly unclear on whether this code is upstream to or vendored from https://github.com/we-like-parsers/pegen
The other way around: that code is adapted from the one in CPython. |
@pablogsal, would you find it helpful to have mypy run on this code in CI at CPython? I'm not generally involved in maintaining |
I think that would be very helpful, indeed, as these types should be up to date 👍 |
Thanks a lot for the PR @sobolevn and thanks for the review @AlexWaygood |
|
Notes:
type: ignore[import]
will be removed aftertypes-setuptools
is installedIncomplete
will be removed as wellmypy
onTools/peg_generator
#108455