Skip to content

[3.12] gh-105699: Re-enable the Multiple-Interpreters Stress Tests (gh-107572) #107783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 8, 2023

We had disabled them due to crashes they exposed, which have since been fixed.
(cherry picked from commit f9e3ff1)

Co-authored-by: Eric Snow [email protected]

…thongh-107572)

We had disabled them due to crashes they exposed, which have since been fixed.
(cherry picked from commit f9e3ff1)

Co-authored-by: Eric Snow <[email protected]>
@ericsnowcurrently
Copy link
Member

Clearly something is off here. I didn't see any problems with the main branch. I'll investigate.

@ambv
Copy link
Contributor

ambv commented Sep 22, 2023

@ericsnowcurrently this currently passes after merging in the latest 3.12 state.

@vstinner
Copy link
Member

vstinner commented Oct 4, 2023

@ericsnowcurrently: This PR was marked as a draft. What is its status?

@ericsnowcurrently ericsnowcurrently marked this pull request as ready for review October 12, 2023 08:10
@ericsnowcurrently
Copy link
Member

Does a8ff5c8 mean I can close this PR?

@Yhg1s
Copy link
Member

Yhg1s commented Nov 20, 2023

Does a8ff5c8 mean I can close this PR?

It means the 3.12 branch was merged into this PR, which I did to make sure the tests still pass. Is this PR still necessary? If not, then you could close it :)

@ericsnowcurrently
Copy link
Member

Ah, thanks for clarifying. I won't close this PR. 😄

@ericsnowcurrently ericsnowcurrently merged commit a4aac7d into python:3.12 Nov 27, 2023
@ericsnowcurrently
Copy link
Member

I'll need to revert this. The problem is on FreeBSD.

ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Nov 27, 2023
@bedevere-app
Copy link

bedevere-app bot commented Nov 27, 2023

GH-112474 is a backport of this pull request to the 3.12 branch.

ericsnowcurrently added a commit that referenced this pull request Nov 27, 2023
…rs Stress Tests" (gh-112474)

Revert "[3.12] gh-105699: Re-enable the Multiple-Interpreters Stress Tests (gh-107572) (#107783)"

This reverts commit a4aac7d.

The stress tests are still failing on FreeBSD.
@ericsnowcurrently
Copy link
Member

I'll retry this (with buildbots this time) once I've merged my other backport PRs.

ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Nov 28, 2023
…sts (pythongh-107572) (python#107783)

We had disabled them due to crashes they exposed, which have since been fixed.
(cherry picked from commit f9e3ff1)

Co-authored-by: Eric Snow <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: T. Wouters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants