gh-106197: Deduplicate tests in test_buffer
#106198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barneygale
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
One key difference between the tests is the order of inheritance, e.g. class B(A, bytearray): vs class B(bytearray, A):, and likewise for the C class. Is it worth mentioning this in a comment at the beginning of test_multiple_inheritance_buffer_last_raising(), so that future readers will spot the difference quickly?
mhmd8497
approved these changes
Jun 28, 2023
mhmd8497
approved these changes
Jun 28, 2023
JelleZijlstra
approved these changes
Jun 28, 2023
|
Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
GH-106206 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 28, 2023
(cherry picked from commit c283a0c) Co-authored-by: Nikita Sobolev <[email protected]>
JelleZijlstra
pushed a commit
that referenced
this pull request
Jun 28, 2023
…6206) gh-106197: Deduplicate tests in `test_buffer` (GH-106198) (cherry picked from commit c283a0c) Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_multiple_inheritance_buffer_lastis duplicated intest_buffer#106197