gh-104527: zippapp will now avoid appending an archive to itself. #106076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #104857 does add an error message that makes it much easier to figure out what is going wrong when calling zipfile.write, some of the stdlib uses of zipfile will run into this issue when recursively zipping a directory into an archive that is a child of said directory.
Sometimes, esp. in zipapp, the desired behavior is to place the contents of foo into foo/deploy.zip, or something like that. (case in point, I discovered #104527 from a project that was trying to do just that.) In this case, zippapp should not simply throw the error that #104857 is adding, but skip over the target archive.
(should I submit another PR doing the same thing for shutil.make_archive, or should we let that one fail with an error?)