gh-105564: Don't include artificial newlines in the line attribute of tokens #105565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pablogsal
commented
Jun 9, 2023
•
pablogsal
commented
- Issue: Artificial newlines show in the "line" attribute of tokens in the tokenizer module #105564
pablogsal
force-pushed
the
newlines
branch
2 times, most recently
from
5fa6e34 to
e4eaa39
Compare
…ute of tokens Signed-off-by: Pablo Galindo <[email protected]>
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 9, 2023
…ute of tokens (pythonGH-105565) (cherry picked from commit d7f46bc) Co-authored-by: Pablo Galindo Salgado <[email protected]>
|
GH-105579 is a backport of this pull request to the 3.12 branch. |
pablogsal
added a commit
that referenced
this pull request
Jun 9, 2023
…bute of tokens (GH-105565) (#105579) Co-authored-by: Pablo Galindo Salgado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.