gh-103646: Remove --include-pip-user from default APPX package build #105064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
added
type-bug
pfmoore
reviewed
May 29, 2023
|
Deprecating and removing a command line option is a bigger change than just changing a preset, since the presets are deliberately unspecified. I doubt anyone is actually using it, but I see no reason to find out by simply removing it. There are potentially useful scenarios that might be using it where they wouldn't be covered by the unwritable-Lib fallback (I know of one such scenario, though I don't know that they're actively using this option). |
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 29, 2023
…build (pythonGH-105064) (cherry picked from commit 6da7015) Co-authored-by: Steve Dower <[email protected]>
|
GH-105065 is a backport of this pull request to the 3.12 branch. |
|
Want to make sure this is in for 3.12.0b2 tomorrow, but we can look at cleaning up unused options later. |
zooba
added a commit
that referenced
this pull request
May 29, 2023
…H-105064) (cherry picked from commit 6da7015) Co-authored-by: Steve Dower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.