Skip to content

gh-104411: Update test_getint for Tcl 9.0 #104412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 6, 2023
Merged

gh-104411: Update test_getint for Tcl 9.0 #104412

merged 4 commits into from
Jun 6, 2023

Conversation

chrstphrchvz
Copy link
Contributor

@chrstphrchvz chrstphrchvz commented May 12, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 12, 2023
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label May 12, 2023
eamanu
eamanu reviewed May 12, 2023
View reviewed changes
terryjreedy
terryjreedy reviewed May 30, 2023
View reviewed changes
@terryjreedy
Copy link
Member

@serhiy-storchaka self.assertEqual(tcl.getint((' %#o ' % i).replace('o', '')), i) fails in tcl 9 for i == 2**31 - 1 == 2147483647 because tcl joins python in treating '017777777777' as decimal. (Note: the string expression is the same as ' %o ' % i. Should we skip the test or change it to test that tcl.getint(s) equals int(s) for such strings?

serhiy-storchaka
serhiy-storchaka reviewed Jun 1, 2023
View reviewed changes
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 6, 2023
@serhiy-storchaka
Delete 2023-05-12-00-57-00.gh-issue-104411.H4m2sS.rst
07f113e 
A NEWS entry is not needed for this trivial PR.
@serhiy-storchaka serhiy-storchaka merged commit 2c49c75 into python:main Jun 6, 2023
@miss-islington
Copy link
Contributor

Thanks @chrstphrchvz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 6, 2023
@chrstphrchvz @miss-islington
pythongh-104411: Update test_getint for Tcl 9.0 (pythonGH-104412)
25e2928 
(cherry picked from commit 2c49c75)

Co-authored-by: Christopher Chavez <[email protected]>
@bedevere-bot
Copy link

GH-105356 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 6, 2023
@chrstphrchvz @miss-islington
pythongh-104411: Update test_getint for Tcl 9.0 (pythonGH-104412)
993b9cf 
(cherry picked from commit 2c49c75)

Co-authored-by: Christopher Chavez <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 6, 2023
@bedevere-bot
Copy link

GH-105357 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 6, 2023
terryjreedy pushed a commit that referenced this pull request Jun 6, 2023
@miss-islington @chrstphrchvz
[3.12] gh-104411: Update test_getint for Tcl 9.0 (GH-104412) (#105356)
260ba1f 
gh-104411: Update test_getint for Tcl 9.0 (GH-104412)
(cherry picked from commit 2c49c75)

Co-authored-by: Christopher Chavez <[email protected]>
terryjreedy pushed a commit that referenced this pull request Jun 6, 2023
@miss-islington @chrstphrchvz
[3.11] gh-104411: Update test_getint for Tcl 9.0 (GH-104412) (#105357)
daf22ca 
gh-104411: Update test_getint for Tcl 9.0 (GH-104412)
(cherry picked from commit 2c49c75)

Co-authored-by: Christopher Chavez <[email protected]>
@chrstphrchvz chrstphrchvz deleted the patch-104411 branch June 6, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

+1 more reviewer

@eamanu eamanu eamanu left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chrstphrchvz @terryjreedy @miss-islington @bedevere-bot @serhiy-storchaka @eamanu @arhadthedev