Skip to content

gh-104051: fix crash in test_xxtestfuzz with -We #104052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2023
Merged

gh-104051: fix crash in test_xxtestfuzz with -We #104052

merged 1 commit into from
May 5, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented May 1, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 1, 2023
Closed
@iritkatriel iritkatriel requested a review from ammaraskar May 1, 2023 18:10
@ammaraskar
Copy link
Member

I think this does fix the issue for now since the deprecation PR adds aliases in the sre_* files (https://github.com/python/cpython/blob/1be3260a90f16aae334d993aecf7b70426f98013/Lib/sre_compile.py)

Longer term we should change this so it directly imports compile from the re module and error from re._constants

@iritkatriel iritkatriel added skip news tests Tests in the Lib/test dir labels May 1, 2023
@iritkatriel iritkatriel merged commit 81fc135 into python:main May 5, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2
8a78a36 
* main: (61 commits)
  pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
  pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
  pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
  pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
  pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
  pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
  pythongh-104190: fix ubsan crash (python#104191)
  pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
  pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
  pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
  pythongh-68968: Correcting message display issue with assertEqual (python#103937)
  pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
  pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
  pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
  pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
  pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
  pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
  pythongh-102500: Document PEP 688 (python#102571)
  pythongh-102500: Implement PEP 688 (python#102521)
  pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
  ...
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@iritkatriel @jbower-fb
pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
4126669
@iritkatriel iritkatriel deleted the fuzztest branch July 25, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammaraskar ammaraskar Awaiting requested review from ammaraskar ammaraskar is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crash in ./python.exe -We -m test -v test_xxtestfuzz
3 participants
@iritkatriel @ammaraskar @bedevere-bot