Skip to content

[3.11] gh-103971: Fix wrong line number generated for match-case blocks #103980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 28, 2023
Merged

[3.11] gh-103971: Fix wrong line number generated for match-case blocks #103980

merged 4 commits into from
Apr 28, 2023

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Apr 28, 2023 •
edited by bedevere-bot
Loading

The residue location issue would cause the case block setting the line number of RETURN_VALUE to the code block just parsed, which confuses debugger to believe the last line of the code block was executed even though it was not.

@bedevere-bot bedevere-bot mentioned this pull request Apr 28, 2023
Closed
brandtbucher
brandtbucher approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix (and welcome to the compiler)!

@brandtbucher brandtbucher enabled auto-merge (squash) April 28, 2023 19:27
@gaogaotiantian
Copy link
Member Author

Thank you for the guidance!

@brandtbucher brandtbucher self-assigned this Apr 28, 2023
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Apr 28, 2023
@brandtbucher
Copy link
Member

Can you open a PR with just the new test against main?

@gaogaotiantian gaogaotiantian mentioned this pull request Apr 28, 2023
Merged
@brandtbucher brandtbucher merged commit fee3c91 into python:3.11 Apr 28, 2023
brandtbucher pushed a commit that referenced this pull request Apr 28, 2023
@gaogaotiantian
GH-103971: Forward-port test from GH-103980 (GH-103984)
79b9db9
@gaogaotiantian gaogaotiantian deleted the 3.11-match-loc-fix branch May 1, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@brandtbucher brandtbucher

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaogaotiantian @brandtbucher @bedevere-bot