Skip to content

GH-103944: Check error status when raising DeprecationWarning #103949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2023
Merged

GH-103944: Check error status when raising DeprecationWarning #103949

merged 2 commits into from
Apr 28, 2023

Conversation

pganssle
Copy link
Member

@pganssle pganssle commented Apr 27, 2023 •
edited by bedevere-bot
Loading

@pganssle pganssle requested a review from abalkin as a code owner April 27, 2023 20:11
@bedevere-bot bedevere-bot mentioned this pull request Apr 27, 2023
Closed
erlend-aasland
erlend-aasland reviewed Apr 27, 2023
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some PEP-7 nits.

@pganssle pganssle force-pushed the utcnow_deprecation_errcheck branch from cecac63 to 0cda214 Compare April 28, 2023 18:50
@pganssle
Copy link
Member Author

@erlend-aasland OK, I've made the relevant changes. Thanks! (My kingdom for an incremental PEP 7 formatter... 😅)

@pganssle pganssle merged commit 689723a into python:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@sobolevn sobolevn Awaiting requested review from sobolevn

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pganssle @erlend-aasland @bedevere-bot