Skip to content

gh-102956: Fix returning of empty byte strings after seek in zipfile … #103565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 24, 2023

Conversation

Jokimax
Copy link
Contributor

@Jokimax Jokimax commented Apr 15, 2023

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@arhadthedev arhadthedev added the stdlib Python modules in the Lib dir label Apr 15, 2023
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Oct 24, 2023
@AlexWaygood AlexWaygood requested a review from gpshead October 24, 2023 15:41
@gpshead gpshead self-assigned this Oct 24, 2023
@gpshead gpshead added the needs backport to 3.12 only security fixes label Oct 24, 2023
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@gpshead gpshead enabled auto-merge (squash) October 24, 2023 20:47
@gpshead gpshead merged commit c73b0f3 into python:main Oct 24, 2023
@miss-islington-app
Copy link

Thanks @Jokimax for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2023
…pfile … (pythonGH-103565)

(cherry picked from commit c73b0f3)

Co-authored-by: Jokimax <[email protected]>
pythongh-102956: Fix returning of empty byte strings after seek in zipfile module. This was a regression in 3.12.0 due to a performance enhancement.
@bedevere-app
Copy link

bedevere-app bot commented Oct 24, 2023

GH-111289 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 24, 2023
gpshead pushed a commit that referenced this pull request Oct 25, 2023
…ipfile … (GH-103565) (#111289)

gh-102956: Fix returning of empty byte strings after seek in zipfile … (GH-103565)
(cherry picked from commit c73b0f3)


gh-102956: Fix returning of empty byte strings after seek in zipfile module. This was a regression in 3.12.0 due to a performance enhancement.

Co-authored-by: Jokimax <[email protected]>
listout pushed a commit to listout/gentoo that referenced this pull request Oct 28, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…pfile … (python#103565)

pythongh-102956: Fix returning of empty byte strings after seek in zipfile module. This was a regression in 3.12.0 due to a performance enhancement.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…pfile … (python#103565)

pythongh-102956: Fix returning of empty byte strings after seek in zipfile module. This was a regression in 3.12.0 due to a performance enhancement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Python modules in the Lib dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants